Jump to content

Proper/Improper noun replacement proposal


SabreML
 Share

Recommended Posts

Details:

  • Files changed: 260
  • Line insertions: 811
  • Line deletions: 811
  • Potential labels: Grammar and Formatting, Tweak/Fix

I've gone through every file I could find in the code with name = "Uppercase Name" and replaced every instance (where needed) with either a lowercase version, or added an \improper so that it displays correctly in-game.

This regex was used to search, but each replacement was done manually to avoid false positives:

\tname\s*=\s*"\s*[A-Z].*"

 

Now obviously this is a lot of changes to go through at once, so my current plan (assuming there's no objections) is to slowly post all of this in multiple smaller 'themed' PRs rather than in one massive one. That way I can go through everything in the 'Weapons' or 'Machinery' categories for example, and double check that I didn't make a mistake somewhere.
Most importantly, this would also have the benefit of making the PRs actually possible to review, because while each change is very easy to check individually, 811 of them at once is not.

Alternatively I could just split this into 130-file chunks, but atomising it seems like the best way to go.


Examples: (Before/After)

1098491134_MITold.thumb.png.9bd4421d35c00ef114c6ddbecff43364.png

1989025437_MITnew.thumb.png.26d95886bfc6ff07d914696b563e7888.png

-----

443444145_NTold.thumb.png.a00097e28cab87ba620e2213988cb3a7.png

1721908920_NTnew.thumb.png.0d2d14566dc128f5329d9d79a572b610.png

-----

1274568070_LAMold.thumb.png.273938891094b56a561f38709059f908.png

244283983_LAMnew.thumb.png.4bcd658946349f00e2a135d76f48d8ae.png

-----

62677321_Analyzerold.thumb.png.d8f67daea42196e55311589a8107a73e.png

122094523_Analyzernew.thumb.png.79c4fad64a06aa561b623930a8f511ac.png

-----

856726870_EVAold.thumb.png.4360b69f3692a1c062c8f39dd3121af2.png

1270056596_EVAnew.thumb.png.aa8deabb3987f8c30b9b24c8992852ac.png

-----

612578659_Gibberold.thumb.png.8e7c4bf36fa0b822de7bae648923efd0.png

37380264_Gibbernew.thumb.png.c41da3e15996f591fc2ce0508d0a1c0d.png

-----

1862295607_Pacmanold.thumb.png.d5ab21e2e37b74d6660a505e9a4d0b7c.png

2105473706_Pacmannew.thumb.png.29a414b178b31d0acdb639c24c42ace9.png


PRs:

  1. https://github.com/ParadiseSS13/Paradise/pull/16897
  2. https://github.com/ParadiseSS13/Paradise/pull/16906
Edited by SabreML
  • Like 3
Link to comment
Share on other sites

3 hours ago, SabreML said:

This regex was used to search, but each replacement was done manually to avoid false positives:

I hope so because mass regex replacements are a gateway to "no thanks"

 

3 hours ago, SabreML said:

Now obviously this is a lot of changes to go through at once, so my current plan (assuming there's no objections) is to slowly post all of this in multiple smaller 'themed' PRs rather than in one massive one.

Please do this

 

 

 

TLDR: Approved, but you have to split this to manageable chunks, or its getting shot.

  • Like 3
Link to comment
Share on other sites

 Share

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Terms of Use