Forum name: AffectedArc07
Characters played: DTX (only character played within the last year)
PRs I have done:
Below is a list of PRs I have done at paradise which I feel have been important for code quality, game performance, and other things such as game <-> discord relations. This is a cut down list of my full amount to keep this short enough.
PRs I have reviewed:
Below is a list of currently open PRs at paradise which I have reviewed. I have not included closed PRs here to keep the list shorter than my previous ones
PRs on other codebases:
I mostly PR'd to TG, which is where these examples are from. I have worked on the base game, as well as external tools such as RUST-G, IconDiffBot, and MapDiffBot. Some examples are below.
Review work for other codebases:
When running a downstream of another codebase, I reviewed almost all of the mirrored down PRs to ensure they were fully compatible with our modified code, which is important considering the bot blind-copies commits over, ones which usually dont compile properly, and required me to manually edit the code to make it compatible before merging. A link of the archived work is here: https://github.com/KeplerStation/KeplerStation/pulls?utf8=✓&q=is%3Apr+is%3Amerged+reviewed-by%3AAffectedArc07
I have also done review work at TG for some minor game PRs, as well as for the tools I host (MapDiffBot & IconDiffBot)
Most common issue on paradise:
I feel the biggest issue at the moment is people making too many PRs without asking maintainers/heads if its something the game actually wants. This adds to the bloat issue and gives the maintainers more work to do, whereas they could have just asked a head or a maintainer if its worth making the PR or not beforehand
What I could change about the coding guidelines:
I would enforce the use of #define for constants and make global variables use the proper GLOB handler. Converting all of these over is on my todo list, as well as making the code DreamChecker compatible. (DreamChecker is a code quality utility for DM which will check things such as proper return types and correct referencing, proc argument validity, etc). Once I add travis unit tests, I would also enforce the code passing all the game unit tests as well as the regular compile.