AffectedArc07

PR Reviewer
  • Content Count

    83
  • Joined

  • Last visited

  • Days Won

    2

AffectedArc07 last won the day on May 29 2019

AffectedArc07 had the most liked content!

Community Reputation

50 Excellent

1 Follower

About AffectedArc07

  • Other groups InGame Verified,
    Github Contributors,
    Members,
    Mentors
  • Rank
    Jr. Member
  • Birthday January 4

Personal Information

  • Byond Account
    affectedarc07

Recent Profile Visitors

1967 profile views
  1. You've been abandoned for a vox
  2. Appropriate weapon to give You'll never steal my beret, it wont happen. Amazing art though.
  3. I suggested this after seeing the remap ingame, and even though I said it ingame, I will say it here aswell. If this remap does get made, this can go infront of map standardisation, because honestly, current robotics is just too damn cramped, especially when you have comparisons such as metastation robotics.
  4. Part of me wonders why you chose project ozone of all packs to make this, but its good nontheless.
  5. Forum name: AffectedArc07 Discord: affected#5359 CKEY: AffectedArc07 Characters played: DTX (only character played within the last year) PRs I have done: Below is a list of PRs I have done at paradise which I feel have been important for code quality, game performance, and other things such as game <-> discord relations. This is a cut down list of my full amount to keep this short enough. https://github.com/ParadiseSS13/Paradise/pull/12966 https://github.com/ParadiseSS13/Paradise/pull/12951 https://github.com/ParadiseSS13/Paradise/pull/12501 https://github.com/ParadiseSS13/Paradise/pull/12116 https://github.com/ParadiseSS13/Paradise/pull/12071 https://github.com/ParadiseSS13/Paradise/pull/11588 https://github.com/ParadiseSS13/Paradise/pull/11475 https://github.com/ParadiseSS13/Paradise/pull/11293 https://github.com/ParadiseSS13/Paradise/pull/11187 https://github.com/ParadiseSS13/Paradise/pull/11368 https://github.com/ParadiseSS13/Paradise/pull/11318 https://github.com/ParadiseSS13/Paradise/pull/10974 https://github.com/ParadiseSS13/Paradise/pull/10740 PRs I have reviewed: Below is a list of currently open PRs at paradise which I have reviewed. I have not included closed PRs here to keep the list shorter than my previous ones https://github.com/ParadiseSS13/Paradise/pull/12965 https://github.com/ParadiseSS13/Paradise/pull/12180 https://github.com/ParadiseSS13/Paradise/pull/10205 PRs on other codebases: I mostly PR'd to TG, which is where these examples are from. I have worked on the base game, as well as external tools such as RUST-G, IconDiffBot, and MapDiffBot. Some examples are below. https://github.com/tgstation/tgstation/pull/49374 https://github.com/tgstation/rust-g/pull/23 https://github.com/tgstation/tgstation/pull/48915 https://github.com/tgstation/IconDiffBot/pull/55 https://github.com/tgstation/tgstation/pull/44231 https://github.com/tgstation/tgstation/pull/44193 Review work for other codebases: When running a downstream of another codebase, I reviewed almost all of the mirrored down PRs to ensure they were fully compatible with our modified code, which is important considering the bot blind-copies commits over, ones which usually dont compile properly, and required me to manually edit the code to make it compatible before merging. A link of the archived work is here: https://github.com/KeplerStation/KeplerStation/pulls?utf8=✓&q=is%3Apr+is%3Amerged+reviewed-by%3AAffectedArc07 I have also done review work at TG for some minor game PRs, as well as for the tools I host (MapDiffBot & IconDiffBot) Most common issue on paradise: I feel the biggest issue at the moment is people making too many PRs without asking maintainers/heads if its something the game actually wants. This adds to the bloat issue and gives the maintainers more work to do, whereas they could have just asked a head or a maintainer if its worth making the PR or not beforehand What I could change about the coding guidelines: I would enforce the use of #define for constants and make global variables use the proper GLOB handler. Converting all of these over is on my todo list, as well as making the code DreamChecker compatible. (DreamChecker is a code quality utility for DM which will check things such as proper return types and correct referencing, proc argument validity, etc). Once I add travis unit tests, I would also enforce the code passing all the game unit tests as well as the regular compile.
  6. I have wanted this for years. My opinion is a lot less valid now than it was 2 months ago but this would be a welcome change.
  7. https://github.com/tgstation/tgstation/pull/20559
  8. I didnt think I needed to write this but people asked so here goes. Reasons for resignation are as follows: - Im not happy the direction the server is going in - I am tired of the way members of this community are treated, not even being informed, let alone asked before big changes happen (The community managers werent even informed of the nickname changes, and thats just one example) - It ate into far too much of my time and honestly just hurt to deal with (Not to mention this shit is literally right in the middle of my finals) Let me just elaborate/debunk a few reasons people thought I was gone: Salt over boxen being removed: I requested that removal as part of my leave Salt over being fired from mentor: I asked to resign as part of my leave The fluff cuff removal PR: I made that, and I dont plan to be a tiger repeat Thanks for a good 2 and a half years, but I am moving to better places now, possibly see some of you around on other servers, but for now, goodbye - AffectedArc07
  9. I like the principle, but I dont like it in practice. It removes the ability for creative nicknames, and also ticks people off just because of broken capitals (The a on arc should be capitalised, and generally makes it more annoying to read.) The sync should be optional, or atleast not extend to nicknames, as people have already started to unsync.