Jump to content

PR Reviewer Application Guidelines & Template


Recommended Posts

PR Reviewers are primarily responsible for:

  • Doing code review on PRs submitted to Github, pointing out errors, problems and issues relating to following our coding standards
  • Setting an example to Github Contributors in terms of PR quality.

PR Reviewers get:

  • Ability to talk in #pr_review on public discord, enabling co-ordination of who is reviewing what PRs.
  • Access to staff discord (not any sensitive player information, just discussions around game design and PRs)
  • Potentially access to live runtime data from the server (may or may not happen, but it is being discussed)

Minimum requirements to apply:

  • Must have established history of making useful PRs and/or PR reviews on our codebase. This includes having the "Github Contributor" forum tag.
  • No recent (within last 6 months) bans or warnings for rule violations on the server
  • Positive attitude and decent communication skills (you must have the ability to educate PR authors as to their mistakes without making them feel attacked)

To apply, assuming you meet the above requirements, fill out the form below and post it as a new thread in this forum.

Template (YOU MUST USE THIS FOR YOUR APPLICATION!):

  • Forum username:
  • Discord (include tag numbers):
  • CKEY (BYOND username):
  • Characters you play in-game:
  • Link to the list of PRs you've done [example: https://github.com/ParadiseSS13/Paradise/pulls/YOURUSERNAME ]:
  • Link to the list of PR reviews you've done [example: https://github.com/ParadiseSS13/Paradise/pulls?utf8=✓&q=is:open reviewed-by:YOURUSERNAME ]:
  • Link to any other examples of your PR work (e.g. on other codebases) to give us an idea for your skill as a PR author:
  • Link to any other examples of your review work (e.g: on other codebases) to give us an idea of your abilities as a PR reviewer:
  • What do you think the most common issue is for PRs submitted to Paradise, and why?
  • If you could make one single change to our coding guidelines, what would it be?
Link to post
Share on other sites
Guest
This topic is now closed to further replies.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Terms of Use